[feat] Add SP and PP kernels for qwen_moe true on policy - #31
Open
maocheng23 wants to merge 2 commits into
Open
Conversation
maocheng23
force-pushed
the
feat/true_on_policy_qwen_moe
branch
4 times, most recently
from
May 23, 2026 02:47
7ac2a80 to
b0679e2
Compare
maocheng23
force-pushed
the
feat/true_on_policy_qwen_moe_sppp
branch
from
May 23, 2026 22:22
61b608e to
d8bb235
Compare
This was referenced May 23, 2026
Co-authored-by: zju-stu-lizheng <lizheng.cs@zju.edu.cn> Co-authored-by: zyxiyy02 <282300612+zyxiyy02@users.noreply.github.com> Co-authored-by: Yi Zhang <1109276519@qq.com>
maocheng23
force-pushed
the
feat/true_on_policy_qwen_moe_sppp
branch
from
May 24, 2026 17:24
d8bb235 to
f2e7113
Compare
maocheng23
marked this pull request as draft
May 24, 2026 17:25
Author
|
Updated this PR with cleanup commit What changed:
Validation on ion7 (
Note: Rejected path: rollout TP4 / SGLang EP2 payload expansion failed during SGLang weight update with CUDA invalid argument, so that temporary Miles experiment was removed and is not part of this PR update. |
maocheng23
force-pushed
the
feat/true_on_policy_qwen_moe_sppp
branch
from
May 25, 2026 17:50
cb0c31f to
7727cdb
Compare
maocheng23
marked this pull request as ready for review
May 25, 2026 18:02
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #30.
Summary
Adds the Megatron-LM training-side support for Qwen3-30B-A3B MoE SP+PP true-on-policy parity.
This PR is one of three coupled PRs that should be reviewed and landed together because they extend the
qwen3_moe_true_on_policy_v1contract to allow Megatron sequence parallel and pipeline parallel training while preserving exact SGLang rollout parity.Companion PRs:
Main Changes
qwen3_moe_true_on_policy_v1contract gate.Validation
Cleaned 8-GPU ion7 real-workload run:
moe_sppp_pr_tp2_pp2_ep2_onpolicy_real3_cleaned_noci_nosave_260524_ion7raysubmit_a9NCtiu6K5dRVCscTP=2,PP=2,EP=2,ETP=1, sequence parallel enabled; SGLang 4 rollout engines, eachTP=2,EP=2.0 MiB.train/train_rollout_logprob_abs_diff=0.0,train/train_rollout_kl=0.0,grad_norm=0.0377418305, weight version1.0, mixed version0.0.train/train_rollout_logprob_abs_diff=0.0,train/train_rollout_kl=0.0,grad_norm=0.0389085777, weight version2.0, mixed version0.0.485.2571sand462.8948s, about2.6-2.9%slower than the previous on-policy no-debug timing run and in the same overhead band versus off-policy.Focused checks after cleanup:
git diff --check53 passed3 passedLocal record:
recovery/qwen3_moe_sppp_clean/journal/2026-05-23-sppp-e2e.md