Skip to content

[fix] attention_output_gate TP slice when num_kv_heads < TP - #22

Merged
Zhichenzzz merged 1 commit into
miles-mainfrom
fix/attention_output_gate_tp
Apr 15, 2026
Merged

[fix] attention_output_gate TP slice when num_kv_heads < TP#22
Zhichenzzz merged 1 commit into
miles-mainfrom
fix/attention_output_gate_tp

Conversation

@Zhichenzzz

Copy link
Copy Markdown

When num_query_groups < tensor_parallel_size (e.g. num_kv_heads=2, TP=4), query heads are sliced per TP rank in get_query_key_value_tensors but the gate tensor is not, causing gate.view(*x.shape) to fail in _apply_output_gate with a shape mismatch.

Fix: after gate reshape, apply the same TP slice as query when num_query_groups < world_size.

Verified with Qwen3.5-35B-A3B TP=4 CP=2 EP=8 (4 training steps passed, logprob_abs_diff stable at 0.01-0.02).

same as the PR in Miles radixark/miles#972

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

When num_query_groups < tensor_parallel_size (e.g. num_kv_heads=2, TP=4),
query heads are sliced per TP rank in get_query_key_value_tensors but the
gate tensor is not, causing gate.view(*x.shape) to fail in
_apply_output_gate with a shape mismatch.

Fix: after gate reshape, apply the same TP slice as query when
num_query_groups < world_size.

Verified with Qwen3.5-35B-A3B TP=4 CP=2 EP=8 (4 training steps passed,
logprob_abs_diff stable at 0.01-0.02).
@Zhichenzzz
Zhichenzzz requested a review from guapisolo April 12, 2026 21:05

@guapisolo guapisolo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on my side. Also ask Yueming for review?

@Zhichenzzz
Zhichenzzz merged commit 923b85b into miles-main Apr 15, 2026
1 check passed
fzyzcjy added a commit that referenced this pull request Jun 5, 2026
…ixes)

Brings in: true-on-policy init (mappings.py _tree_all_reduce_sum +
_DeterministicReduceFromModelParallelRegion, miles_megatron_plugins/true_on_policy,
gpt_layer_specs use_true_on_policy_backend) + plugin packaging (#49, #50) + fixes
(param dtype before DDP wrap #24, attention_output_gate TP slice #22, fp32 shard
detach).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants