[fix] attention_output_gate TP slice when num_kv_heads < TP - #22
Merged
Conversation
When num_query_groups < tensor_parallel_size (e.g. num_kv_heads=2, TP=4), query heads are sliced per TP rank in get_query_key_value_tensors but the gate tensor is not, causing gate.view(*x.shape) to fail in _apply_output_gate with a shape mismatch. Fix: after gate reshape, apply the same TP slice as query when num_query_groups < world_size. Verified with Qwen3.5-35B-A3B TP=4 CP=2 EP=8 (4 training steps passed, logprob_abs_diff stable at 0.01-0.02).
guapisolo
approved these changes
Apr 13, 2026
guapisolo
left a comment
There was a problem hiding this comment.
LGTM on my side. Also ask Yueming for review?
fzyzcjy
added a commit
that referenced
this pull request
Jun 5, 2026
…ixes) Brings in: true-on-policy init (mappings.py _tree_all_reduce_sum + _DeterministicReduceFromModelParallelRegion, miles_megatron_plugins/true_on_policy, gpt_layer_specs use_true_on_policy_backend) + plugin packaging (#49, #50) + fixes (param dtype before DDP wrap #24, attention_output_gate TP slice #22, fp32 shard detach).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When num_query_groups < tensor_parallel_size (e.g. num_kv_heads=2, TP=4), query heads are sliced per TP rank in get_query_key_value_tensors but the gate tensor is not, causing gate.view(*x.shape) to fail in _apply_output_gate with a shape mismatch.
Fix: after gate reshape, apply the same TP slice as query when num_query_groups < world_size.
Verified with Qwen3.5-35B-A3B TP=4 CP=2 EP=8 (4 training steps passed, logprob_abs_diff stable at 0.01-0.02).
same as the PR in Miles radixark/miles#972
What does this PR do ?
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.