Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix step show selected rows in Data-table component #646

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

Lol1chw
Copy link
Contributor

@Lol1chw Lol1chw commented Jul 5, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Changed the documentation for the Data-table component to improve DX.

Continuation of the step-by-step guide to creating a table using different APIs

πŸ“Έ Screenshots (if appropriate)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Jul 8, 2024

Can you share an image or video about the PR changes, thanks

@Lol1chw
Copy link
Contributor Author

Lol1chw commented Jul 8, 2024

Sure, here's the video:
https://github.com/radix-vue/shadcn-vue/assets/94941930/6b940ab4-1803-4e42-9871-11275db3520a

@sadeghbarati
Copy link
Collaborator

https://www.material-react-table.com/docs/examples/expanding-tree

I was expecting something like this chevron/arrow icon in the first column to expand the row, but this is a nice usecase too

@sadeghbarati sadeghbarati merged commit 9ddbd5c into radix-vue:dev Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants