fix(Combobox): update AcceptableValue
inside Combobox.vue
#677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please first read this issue: radix-vue/shadcn-vue#327
So I delved deeper inside
radix-vue
codebase and searched thattype AcceptableValue = string | number | boolean | object
But
object
type inside TS is more that just object we think about:type
Object
don't feet too I think:So I think that the best
object
for this values will bePlainObject
:So, this PR change
object
toRecord<string, any>
If you think about other edge cases, I'm open to chat and discussion 🙂