[Popper] Add collision strategy option #2928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives a way to control how popper placement collision is handled, either using flip or shift middlewares from Floating UI. By default, it is set to flip for backwards compatibility. Fixes issue radix-ui#2842 * [Popper] Updated storybook
mazei513
requested review from
benoitgrelard,
andy-hook,
vladmoroz and
lucasmotta
as code owners
|
Much needed functionality, are there any updates? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
collisionStrategyprop toPopper.Contentto control how the placement is done when it collides with a boundary. The two options are'flip'and'shift'.'flip'is how it is currently done, where it uses theflipmiddleware from Floating UI. The new option for'shift'will instead rely on theshiftmiddleware, which is already used to avoid collisions for the alignment, but using this option also uses it for the side collision.Fixes #2842