proper version info

[andre-merzky]

log flux version

[gemini-code-assist]

Summary of Changes

Hello @andre-merzky, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors how Flux version information is managed within the radical.utils.flux module. The primary goal is to improve clarity and diagnostic capabilities by separating the concept of a Flux API compatibility mode from the actual detailed version string. This ensures that the specific Flux version in use is accurately captured and logged, which can be crucial for debugging and understanding system configurations.

Highlights

• Separation of Flux Version and Mode: The pull request introduces a clear distinction between the Flux API mode (an integer 0 or 1 indicating compatibility) and the detailed Flux version string (obtained from flux --version).
• New mode Property: A new mode property has been added to FluxModule to specifically expose the integer API compatibility mode.
• Enhanced Version Logging: Both FluxHelperV0 and FluxHelperV1 now log the full output of the flux --version command during their initialization, providing more detailed diagnostic information.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

❌ Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.17%. Comparing base (5c4cab3) to head (c3a45fe).

Files with missing lines	Patch %	Lines
src/radical/utils/flux/flux_module.py	64.70%	6 Missing ⚠️
src/radical/utils/flux/flux_helper_v0.py	0.00%	2 Missing ⚠️
src/radical/utils/flux/flux_helper_v1.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            devel     #450      +/-   ##
==========================================
- Coverage   61.23%   61.17%   -0.06%     
==========================================
  Files          66       66              
  Lines        7359     7372      +13     
==========================================
+ Hits         4506     4510       +4     
- Misses       2853     2862       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Code Review

This pull request introduces logging for the flux version and refactors how the flux helper version is determined. The changes are a good step forward, but I've identified a critical bug that could lead to a crash, as well as some opportunities to improve code maintainability by reducing duplication. Please see my detailed comments below.