stable service startup and port selection #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtitov
reviewed
Apr 15, 2025
src/radical/utils/zmq/server.py
Outdated
|
|
||
| addr = Url(as_string(self._sock.getsockopt(zmq.LAST_ENDPOINT))) | ||
| addr.host = get_hostip() | ||
| addr = zmq_bind(self._sock) |
Collaborator
There was a problem hiding this comment.
this disregards provided url (proto, iface, and ports)
p.s., would be good to combine/merge misc.find_port with zmq.server.Server._iterate_ports and then extend zmq.utils.zmq_bind to handle provided url as it is done for Server
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #446 +/- ##
==========================================
- Coverage 61.23% 61.12% -0.11%
==========================================
Files 66 66
Lines 7359 7324 -35
==========================================
- Hits 4506 4477 -29
+ Misses 2853 2847 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andre-merzky
commented
May 9, 2025
| # | ||
| def find_port(port_min=10000, port_max=65535): | ||
| def find_port(port_min: int = None, | ||
| port_max: int = None) -> Union[int, None]: |
Collaborator
|
@andre-merzky there are couple comments here, if this PR is crucial/important do we want that comments to be addressed before merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies
xGFabricdeplyment, and service deployment in general