Import backends from RHAPSODY

[mturilli]

Removes the backends, imports them from rhapsody (dev branch of the GH repo for now), and leaves open the possibility to import backends not included from rhapsody.

[gemini-code-assist]

Summary of Changes

Hello @mturilli, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the project's execution backend architecture by migrating the implementation of several key backends to the external rhapsody library. This change aims to centralize backend logic, reduce code duplication, and leverage rhapsody as a dedicated dependency for workflow execution. A robust compatibility layer has been introduced to ensure that the system remains functional and adaptable, gracefully handling scenarios where optional backends or the rhapsody library itself might not be fully available.

Highlights

• Backend Externalization: The core execution backends (Concurrent, Dask, Noop, Radical Pilot) have been removed from the local codebase and are now imported directly from the rhapsody library.
• Rhapsody Dependency: The pyproject.toml file has been updated to include rhapsody as a new dependency, specifically pulling from its dev branch.
• Compatibility Layer: A new base.py module in src/radical/asyncflow/backends introduces a compatibility layer, providing fallback abstract definitions for BaseExecutionBackend and Session if rhapsody is not installed.
• Conditional Backend Imports: Optional backends like Dask and Radical Pilot are now imported conditionally, allowing the system to function even if their respective dependencies (and thus rhapsody's full feature set) are not available.
• Development Environment Cleanup: The .gitignore file has been expanded to ignore various development-related configuration directories and files, such as .vscode/, .github/instructions, .codacy/, .devcontainer/, .direnv/, and .envrc.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the backend system to import backends from the rhapsody package, removing the local implementations. The changes introduce a new dependency on rhapsody from its dev branch and set up a compatibility layer. My review focuses on the new dependency management, code structure, and potential for simplification. I've identified a high-risk dependency practice and several opportunities to reduce code duplication and remove potentially dead code.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[mturilli]

@gemini-code-assist review

[gemini-code-assist]

Code Review

This pull request introduces a significant and well-designed refactoring to a plugin-based architecture for execution backends, moving the Dask and Radical-Pilot backends to the rhapsody library. The changes greatly improve modularity and extensibility. The addition of new testing infrastructure for the plugin system and pre-commit hooks for quality assurance are also valuable contributions. My review includes a few suggestions for improvement, mainly concerning a potential security vulnerability, code clarity, and removal of dead code. Overall, this is a high-quality pull request.

[gemini-code-assist]

Code Review

This pull request introduces a significant and well-executed refactoring of the backend execution system by moving optional backends to the rhapsody library and implementing a plugin-based architecture with a factory and registry. This greatly improves modularity and extensibility. The addition of pre-commit hooks and new tests for the plugin system are excellent for maintaining code quality. The changes are clean and the new architecture is well-designed. I have a couple of minor suggestions for code cleanup and improving type hinting, but overall this is a great contribution.

[mturilli]

@AymenFJA, this is now ready to be taken for a spin. It uses the dev branch of Rhapsody, and once it is merged, we will be able to use the' master' branch. If everything works, I am happy to publish Rhapsody to PyPI, which will avoid the need to install from GitHub.