warn on unbalanced resource accounting

[andre-merzky]

This check ensures that resource accounting is balanced.

[gemini-code-assist]

Summary of Changes

Hello @andre-merzky, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR adds a crucial check to src/radical/analytics/utils/plot.py to identify and warn about unbalanced resource accounting. It introduces a new tracking mechanism using defaultdict to sum resource contributions for each metric. If any metric's total contributions do not sum to zero, a detailed warning is printed, highlighting the imbalance. This helps ensure the integrity of resource allocation tracking.

Highlights

• PR Intent: This pull request introduces a new check to detect and warn about unbalanced resource accounting within the get_pilot_series function. The goal is to ensure that resource allocations and deallocations are properly balanced, flagging any discrepancies.
• Changes Summary: The changes are confined to src/radical/analytics/utils/plot.py. Key modifications include:

1. New Imports: Added pprint and defaultdict for enhanced data handling and output.
2. Resource Balance Tracking: A defaultdict(list) named check is introduced to meticulously track resource contributions (both positive and negative) for each metric and state transition.
3. Unbalanced Accounting Warning: After processing all resource transitions for an entity, the code now iterates through the check dictionary. If the sum of contributions for any metric is not zero, a warning message is printed to stdout, detailing the entity, the unbalanced metric, and the total imbalance. It also provides a breakdown of contributions for all metrics if an imbalance is detected.

• Reviewer Activity Summary: No reviewer activity has been recorded or provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR adds resource accounting validation to ensure that resource contributions are balanced across state transitions. It introduces a warning system that detects when resource allocations and deallocations don't sum to zero.

• Added resource accounting validation using a defaultdict to track contributions
• Implemented warning system to detect unbalanced resource accounting
• Enhanced debug output to include entity UIDs in print statements

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

❌ Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.96%. Comparing base (795f7da) to head (02786c4).
⚠️ Report is 3 commits behind head on devel.

Files with missing lines	Patch %	Lines
src/radical/analytics/utils/plot.py	8.33%	11 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            devel     #207      +/-   ##
==========================================
- Coverage   23.11%   22.96%   -0.15%     
==========================================
  Files           7        7              
  Lines        1194     1206      +12     
==========================================
+ Hits          276      277       +1     
- Misses        918      929      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Code Review

This pull request adds a check for unbalanced resource accounting, which is a valuable addition for ensuring data integrity. My review focuses on improving the implementation of this check for better performance, deterministic behavior, and adherence to best practices for library code.

[mtitov]

LGTM! Thanks!