Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add biome formatter #339

Merged
merged 3 commits into from
Jan 18, 2025
Merged

feat: add biome formatter #339

merged 3 commits into from
Jan 18, 2025

Conversation

danielpza
Copy link
Contributor

@danielpza danielpza commented Dec 25, 2024

See https://biomejs.dev/

Alternative formatter to prettier

closes #323

Comment on lines -1180 to +1181
(buffer-local-value 'lisp-indent-function buffer))
(buffer-local-value 'lisp-indent-function buffer))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted the indentation in this line to be consistent with the whole file. I can revert it if undesired.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oof. Thanks for fixing that.

@@ -35,6 +35,7 @@
"-"))
(brittany . ("brittany"))
(buildifier . ("buildifier"))
(biome . ("apheleia-npx" "biome" "format" "--stdin-file-path" filepath))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - format does not sort imports (for some strange reason), however applying both check and --fix to the command then it does.

Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is great, sorry for the delay!

@raxod502 raxod502 merged commit fa50cb3 into radian-software:main Jan 18, 2025
4 checks passed
@danielpza danielpza deleted the biomejs branch January 18, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add biomejs as a lint option
3 participants