Swift5 & Xcode 10.2 #48
Conversation
Updated watchOS deployment target to 3.0 because that’s now minimum for AppStoreConnect. Bumped version.
|
I think Travis-CI should be reconfigured to exit without errors, but code looks fine. @radex, can you review this MR? |
|
@radianttap could you edit the |
|
I never used Travis thus I have no idea what to edit. I believe owners can edit the PR..? |
|
@radianttap unfortunately I'm not an owner so I cannot edit the file myself. Basically, you just have to update the value for https://github.com/radex/SwiftyTimer/blob/master/.travis.yml
|
|
Ok, done. |
|
Looks like line 20 must be changed as well to update the target operating system: |
|
Chasing Travis tail, done. |
|
Thanks! @radex can you review? |
|
@antoinelamy Sorry, I don't maintain this project anymore — @asowers1 does. |
SwiftyTimer.podspec
Outdated
| s.license = 'MIT' | ||
| s.summary = 'Swifty API for NSTimer' | ||
| s.homepage = 'https://github.com/radex/SwiftyTimer' | ||
| s.authors = { 'Radek Pietruszewski' => '[email protected]' } | ||
| s.source = { git: 'https://github.com/radex/SwiftyTimer.git', tag: s.version } | ||
| s.swift_version = '4.2' | ||
|
|
||
| s.swift_version = '5.0' |
There was a problem hiding this comment.
This line should not be required as swift_versions is defined later on and overwrites it.
There was a problem hiding this comment.
At the time when I added that, swift_versions was new so newer CocoaPods was using it while older ones ignored it. I agree, this can now be updated to just one setting, I believe everyone has moved on.
|
@asowers1 review please? |
Code works on its own, just config stuff