Skip to content

Comments

Use -Wno-cpp to avoid errors on #warning#17785

Merged
XVilka merged 2 commits intoradareorg:masterfrom
ret2libc:capstone-wnocpp
Oct 14, 2020
Merged

Use -Wno-cpp to avoid errors on #warning#17785
XVilka merged 2 commits intoradareorg:masterfrom
ret2libc:capstone-wnocpp

Conversation

@ret2libc
Copy link
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description

See #17781 (comment) . I've seen this option in https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html .

Test plan

Everything should be green, capstone included.

@ret2libc ret2libc requested a review from trufae as a code owner October 14, 2020 06:11
@ret2libc ret2libc requested a review from XVilka October 14, 2020 06:11
@github-actions github-actions bot added the infrastructure Issues related to the radare2/cutter infrastructure label Oct 14, 2020
@XVilka
Copy link
Contributor

XVilka commented Oct 14, 2020

Good. Still needs to fix one more:

gcc -Ilibr/asm/8a8d21f@@r_asm@sha -I. -I../ -I../libr/include -Ilibr/asm/../../shlr -I../libr/asm/../../shlr -I../libr/asm/arch/include -I../libr/asm/arch -I../libr/asm/arch/h8300 -I../libr/asm/arch/hexagon -I../libr/asm/arch/msp430 -I../libr/asm/arch/rsp -I../libr/asm/arch/mcore -I../libr/asm/arch/v850 -I../libr/asm/arch/propeller -I../libr/asm/arch/ebc -I../libr/asm/arch/cr16 -I../libr/asm/arch/8051 -I../libr/asm/arch/v810 -I../libr/asm/arch/or1k -I../shlr/spp -I../shlr/sdb/src -I../shlr/zip/zlib -I../shlr/capstone/include -I../shlr/java -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -g -fvisibility=hidden -Werror -Wno-cpp -fPIC -pthread -DR2_PLUGIN_INCORE=1 -MD -MQ 'libr/asm/8a8d21f@@r_asm@sha/p_asm_tms320.c.o' -MF 'libr/asm/8a8d21f@@r_asm@sha/p_asm_tms320.c.o.d' -o 'libr/asm/8a8d21f@@r_asm@sha/p_asm_tms320.c.o' -c ../libr/asm/p/asm_tms320.c
../libr/asm/p/asm_tms320.c:15:12: error: ‘cd’ defined but not used [-Werror=unused-variable]
 static csh cd = 0;
            ^~
cc1: all warnings being treated as errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Issues related to the radare2/cutter infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants