Fixes misses closing '/' in component declaration #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The component declaration 'Component' is missing a now-required '/' on the tag. As is stands the example fails. Is there not a better way of ensuring that documentation samples stay up-to-date and correct? As it's the first port-of-call for people learning a feature, if the examples are wrong, it doesn't create a good experience, especially as one assumes that one's own code is wrong, rather than the example. Maybe embed a fiddle instead of the raw code? Then this can be easily tested on each new release.
|
Something like: https://jsfiddle.net/worthaboutapig/jhrgcmLk/ in which I've tried to make the code better explain the setting... at least I think so ;) |
|
Documentation and other sections of the ractivejs.org domain is currently being migrated and merged over to https://ractive.js.org/. The new repo is now at https://github.com/ractivejs/ractivejs.github.io. We will sunset this repo and site along with the others when we get to it.
Yep, I agreed 102%. The typo might still exist in the new repo though. I still have to review all the verbiage and links when I get the time, even for the legacy docs. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The component declaration 'Component' is missing a now-required '/' on the tag. As is stands the example fails.
Is there not a better way of ensuring that documentation samples stay up-to-date and correct? As it's the first port-of-call for people learning a feature, if the examples are wrong, it doesn't create a good experience, especially as one assumes that one's own code is wrong, rather than the example.
Maybe embed a fiddle instead of the raw code? Then this can be easily tested on each new release.