Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security improvements for Kibana/Nginx #169

Merged
merged 2 commits into from
Sep 8, 2015
Merged

Security improvements for Kibana/Nginx #169

merged 2 commits into from
Sep 8, 2015

Conversation

jimmycuadra
Copy link
Contributor

This branch includes one change and one addition related to security and Kibana's web server:

  • Disallow the SSLv3 protocol which is vulnerable to POODLE. Update the allowed TLS cipher suite according to current best practices.

    Reference: https://raymii.org/s/tutorials/Strong_SSL_Security_On_nginx.html.

  • Add a new attribute, ['elkstack']['config']['kibana']['prepare_ssl'] which allows users to disable the kibana_ssl recipe if they wish to configure this themselves (including providing their own certificate and private key). The default is true, meaning the behaivor stays as it is by default.

@jimmycuadra
Copy link
Contributor Author

CI failure looks like a configuration problem... This passed kitchen test for me locally.

@martinb3
Copy link
Contributor

martinb3 commented Sep 8, 2015

@jimmycuadra Thanks for the contribution! CircleCI won't build branches owned by a non-project/non-approved owner, as it could potentially expose secrets. This is expected behavior. I've pushed a branch with your changes into the main git repo, so that they will be tested appropriately.

@martinb3
Copy link
Contributor

martinb3 commented Sep 8, 2015

Looks like this ended up choking on a current rubocop gem issue: rubocop/rubocop#2218

I've added ff15484 and it did pass in CircleCI after that, so I'm going to manually merge, and it will include your commits. Thank you for the contribution @jimmycuadra!

@martinb3 martinb3 merged commit c59556a into rackspace-cookbooks:master Sep 8, 2015
@jimmycuadra
Copy link
Contributor Author

Thanks for merging! If you think of it, please leave a comment here when a new version is uploaded to the Supermarket so I can update my wrapper cookbook. :}

@martinb3
Copy link
Contributor

martinb3 commented Sep 8, 2015

@jimmycuadra No problem! I pushed 6.0.4 with your changes, so you should be all set to use Supermarket again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants