Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ~bits defined type for bandwidth #21

Closed
rezib opened this issue Oct 27, 2023 · 0 comments · Fixed by #22
Closed

Add ~bits defined type for bandwidth #21

rezib opened this issue Oct 27, 2023 · 0 comments · Fixed by #22
Assignees
@rezib
Labels
enhancement New feature or request

Comments

@rezib
Copy link
Contributor

rezib commented Oct 27, 2023

The type of NodeTypeNetif.bandwidth is currently in ~bytes but network bandwidths are usually in [kMGT]bits per seconds, then it would be more natural to express these bandwidths with an additional defined type named ~bits.
@rezib rezib self-assigned this Oct 27, 2023
rezib added a commit that referenced this issue Oct 27, 2023
@rezib
refactor(schema): use ~bits for all bandwiths
9031a7a 
Use ~bits defined type instead of ~bytes for NodeTypeNetif,
StorageEquipmentTypeNetif and NetworkEquipmentTypeNetif bandwidth
properties.

fix #21
@rezib rezib mentioned this issue Oct 27, 2023
Merged
@rezib rezib closed this as completed in #22 Oct 27, 2023
rezib added a commit that referenced this issue Oct 27, 2023
@rezib
refactor(schema): use ~bits for all bandwiths
67bbf92 
Use ~bits defined type instead of ~bytes for NodeTypeNetif,
StorageEquipmentTypeNetif and NetworkEquipmentTypeNetif bandwidth
properties.

fix #21
@rezib rezib added the enhancement New feature or request label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rezib rezib

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set bandwidths type to bits instead of bytes rackslab/RacksDB
1 participant
@rezib