Skip to content

Automated Resyntax fixes #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Automated Resyntax fixes #772

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9cced4a
Fix 1 occurrence of `nested-when-to-compound-when`
resyntax-ci[bot] Oct 5, 2025
a560305
Fix 1 occurrence of `and-let-to-cond`
resyntax-ci[bot] Oct 5, 2025
8b6e6f6
Fix 1 occurrence of `map-to-for`
resyntax-ci[bot] Oct 5, 2025
10818d4
Fix 1 occurrence of `andmap-to-for/and`
resyntax-ci[bot] Oct 5, 2025
2804304
Fix 3 occurrences of `string-append-with-format-to-format`
resyntax-ci[bot] Oct 5, 2025
747d8b2
Fix 3 occurrences of `for-each-to-for`
resyntax-ci[bot] Oct 5, 2025
e53e8c2
Fix 7 occurrences of `let-to-define`
resyntax-ci[bot] Oct 5, 2025
4b8dd83
Fix 1 occurrence of `define-lambda-to-define`
resyntax-ci[bot] Oct 5, 2025
59d6205
Fix 1 occurrence of `define-lambda-to-curried-define`
resyntax-ci[bot] Oct 5, 2025
f3b9ed0
Fix 1 occurrence of `quasiquote-to-list`
resyntax-ci[bot] Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions drracket-core-lib/drracket/private/syncheck/gui.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2132,9 +2132,8 @@ If the namespace does not, they are colored the unbound color.
(define/public (syncheck:clear-error-message)
(define old-error-report-visible? error-report-visible?)
(turn-off-error-report)
(when old-error-report-visible?
(when (is-current-tab?)
(send (get-frame) hide-error-report))))
(when (and old-error-report-visible? (is-current-tab?))
(send (get-frame) hide-error-report)))

Copy link
Member

@rfindler rfindler Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged one of these before, but I'm not convinced of this one. The indentation savings in this example isn't serious but the and makes it a bit harder to read, especially since it is all on one line.

Copy link
Collaborator

@jackfirth jackfirth Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I find this kind of thing more readable because it's easier to check that the code following it is outside the when. But maybe there's some room for nuance about when the rule is worth applying. I'll give it some thought. Let me know if you see other instances of this rule that seem off to you.

Copy link
Member

@rfindler rfindler Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this particular instance it is not helping that the two arguments to the "and" are on the same line. I think I would not see much difference between the two if the revised version had also taken 3 lines.

(define/public (syncheck:clear-highlighting)
(define definitions (get-defs))
Expand Down