Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Configuration class #446

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Extract Configuration class #446

merged 1 commit into from
Oct 16, 2019

Conversation

fatkodima
Copy link
Contributor

Extraction for #442

grzuy
grzuy reviewed Oct 16, 2019
View reviewed changes
Copy link
Collaborator

@grzuy grzuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!
Thank you.

lib/rack/attack.rb Outdated Show resolved Hide resolved
lib/rack/attack.rb Outdated Show resolved Hide resolved
@fatkodima
Copy link
Contributor Author

Updated.

@grzuy grzuy merged commit a67a7bf into rack:master Oct 16, 2019
@grzuy
Copy link
Collaborator

grzuy commented Oct 16, 2019

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzuy grzuy grzuy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fatkodima @grzuy