Fix reset! when using namespaced cache store

rack · Nov 4, 2024 · f09caad · f09caad
1 parent 427fdfa
commit f09caad
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/rack/attack/cache.rb b/lib/rack/attack/cache.rb
@@ -55,7 +55,7 @@ def delete(unprefixed_key)
 
       def reset!
         if store.respond_to?(:delete_matched)
-          store.delete_matched("#{prefix}*")
+          store.delete_matched(/#{prefix}*/)
         else
           raise(
             Rack::Attack::IncompatibleStoreError,

diff --git a/spec/rack_attack_spec.rb b/spec/rack_attack_spec.rb
@@ -124,5 +124,18 @@
         _(redis.get("#{Rack::Attack.cache.prefix}::key")).must_be_nil
       end
     end
+
+    if defined?(ActiveSupport::Cache::MemoryStore)
+      it 'should delete rack attack keys' do
+        memory_store = ActiveSupport::Cache::MemoryStore.new(namespace: 'ns')
+        memory_store.write('key', 'value')
+        memory_store.write("#{Rack::Attack.cache.prefix}::key", 'value')
+        Rack::Attack.cache.store = memory_store
+        Rack::Attack.reset!
+
+        _(memory_store.read('key')).must_equal 'value'
+        _(memory_store.read("#{Rack::Attack.cache.prefix}::key")).must_be_nil
+      end
+    end
   end
 end