Add rust-toolchain file #1122
Merged
Add rust-toolchain file #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that people will always have the correct nightly build that this works with. It also makes sure the build is reproducible (as different nightly version might behave differently).
|
Thanks, but I fear it can be outdated too quickly. Maybe binary release (#1119) is better. |
|
I still think it would make a lot of sense in terms of reproducibility for distro packagers like me. Maybe consider maintaining a Probably it doesn't get outdated that quickly. |
|
OK, now I think I understand the merit and decided to merge this for now, though I'm not sure I can handle this effectively. |
|
Sadly and ironically, as it turns out, the particular version 2020-07-21 is broken. I'm using nightly-2020-07-20 and that works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that people will always have the correct nightly build that this works with. It also makes sure the build is reproducible (as different nightly version might behave differently).