Conversation
Update rustc-ap-syntax to 491.0.0.
Contributor
Author
Collaborator
|
Thanks!
Thanks you for trying that. |
Contributor
Author
|
Could you make a point release so that we could update the dependencies of rls? |
Collaborator
|
Sure. Now I'm doing some bug fixes and I'll release it by today. |
Collaborator
|
Released 2.1.23 now. |
Contributor
Author
|
@kngwyu Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update rustc-ap-syntax to 491.0.0.
Note that I am just passing edition 2018 to
syntax::with_globals. Ideally, we should pass the correct edition to it, but I find it to require quite a lot of code refactoring, and I basically gave up. Since the current implementation of racer does not seem to properly set the correct edition anyway, I am assuming that there will be no breaking change introduced with this PR.