Skip to content

DOI-75 Add static astroid version and fix pep8 violations. - #402

Closed
hetmantsev wants to merge 3 commits into
ficus-rgfrom
ficus-rg-fix-quality
Closed

DOI-75 Add static astroid version and fix pep8 violations. #402
hetmantsev wants to merge 3 commits into
ficus-rgfrom
ficus-rg-fix-quality

Conversation

@hetmantsev

@hetmantsev hetmantsev commented Jun 28, 2018

Copy link
Copy Markdown

Description: Fixing quality tests for ficus-rg branch

  1. Updated astroid version fixes error with "ImportError: cannot import name InferenceContext"

Youtrack: DOI-75

Merge deadline: As soon as possible

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Commits are squashed

Post merge:

  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@hetmantsev hetmantsev changed the title DOI-75 Add static astroid version (from ginkgo). DOI-75 Add static astroid version and fix pep8 violations. Jun 28, 2018
@hetmantsev
hetmantsev force-pushed the ficus-rg-fix-quality branch from ead02be to 8426e93 Compare June 28, 2018 08:09
@hetmantsev
hetmantsev force-pushed the ficus-rg-fix-quality branch from 8426e93 to 4ff615c Compare June 28, 2018 08:31
@codecov

codecov Bot commented Jun 28, 2018

Copy link
Copy Markdown

Codecov Report

Merging #402 into ficus-rg will decrease coverage by 0.11%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ficus-rg     #402      +/-   ##
============================================
- Coverage     94.75%   94.64%   -0.12%     
============================================
  Files          1670     1670              
  Lines        157816   157816              
============================================
- Hits         149546   149360     -186     
- Misses         8270     8456     +186
Impacted Files Coverage Δ
lms/djangoapps/dashboard/sysadmin.py 52.89% <ø> (ø) ⬆️
lms/djangoapps/shoppingcart/models.py 96.24% <ø> (ø) ⬆️
...jangoapps/certificates/tests/test_webview_views.py 99.79% <ø> (ø) ⬆️
...e/management/commands/tests/test_import_library.py 70.27% <ø> (-29.73%) ⬇️
lms/djangoapps/instructor_task/models.py 94.73% <100%> (ø) ⬆️
lms/djangoapps/bulk_email/models.py 68.13% <100%> (-26.38%) ⬇️
...contentstore/management/commands/import-library.py 66.66% <100%> (-25%) ⬇️
lms/djangoapps/instructor/enrollment.py 91.39% <100%> (-4.84%) ⬇️
openedx/core/djangoapps/dark_lang/middleware.py 100% <100%> (ø) ⬆️
pavelib/assets.py 50.56% <75%> (-31.54%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fc684...7be3a96. Read the comment docs.

@hetmantsev

Copy link
Copy Markdown
Author

start unit tests

@hetmantsev

Copy link
Copy Markdown
Author

start quality tests

@hetmantsev

Copy link
Copy Markdown
Author

start unit tests

@hetmantsev hetmantsev closed this Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant