Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module version check is overly strict #101

Closed
raboof opened this issue May 14, 2019 · 0 comments
Closed

Module version check is overly strict #101

raboof opened this issue May 14, 2019 · 0 comments
Labels
development issues that don't impact end users directly

Comments

@raboof
Copy link
Owner

raboof commented May 14, 2019

During development you might get errors like:

/usr/local/lib/notion/mod/mod_dock.so: Module version mismatch: expected '3-2019050101-544-gb8eeb757+20190514-2226', found '3-2019050101-544-g7e9ebc87'. Refusing to use.

when doing a make install without make clean.

This is overly strict. The version check should (at least) ignore everything after the +, and perhaps even only warn (and not refuse to load).
@raboof raboof added the development issues that don't impact end users directly label May 19, 2019
@raboof raboof closed this as completed in 7b80dde Mar 15, 2021
raboof added a commit that referenced this issue Mar 15, 2021
@raboof
Merge pull request #323 from raboof/fuzzy-match-module-version
014cf7a 
Relax module version check strictness (fixes #101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development issues that don't impact end users directly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raboof