Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/list of types #77

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Bugfix/list of types #77

merged 3 commits into from
Oct 9, 2023

Conversation

pavlemarinkovic
Copy link
Contributor

With this release we are:

  • Mapping all nf schema properties to cwl schema. This will ensure that is sb platform starts offering support for some of the nextflow specific schema properties, these properties are recorded in the CWL schema file.
  • Using sbg categories to group inputs based on the nextflow schema file definitions.
  • Using yaml instead of ruamel.yaml
  • Parsing revision-note input as a single string now. This is more intuitive than the last method of parsing as a list of strings.
  • Increasing PACKAGE_SIZE_LIMIT from 100 MB to 256 MB. This will avoid issues with some fringe cases where the package size is a bit larger than 100 MB.
  • Using the same pack method to load sb_schema files as sbpack. In some cases when the user provided sb_schema was not properly defined, this would resolve and fix those issues.
  • Excluding hidden .git directory from the app archive. This hidden directory has a tendency to balloon the size of package archives to well above the PACKAGE_SIZE_LIMIT.
  • Fixing profile parsing. With the last release, only a single profile was getting passed as input.

Map all nf schema properties to cwl
Use sbg categories to group inputs
Using yaml instead of ruamel.yaml
revision-note input is now single string
Increase PACKAGE_SIZE_LIMIT from 100 MB to 256 MB
Use pack to load sb_schema
Exclude hidden .git directory from the app archive
Cleanup temporary directory
Fix profile parsing
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (992194b) 97.82% compared to head (0580045) 97.81%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   97.82%   97.81%   -0.02%     
==========================================
  Files           5        5              
  Lines         138      137       -1     
==========================================
- Hits          135      134       -1     
  Misses          3        3              
Files Coverage Δ
tests/test_packing.py 100.00% <100.00%> (ø)
tests/test_pulling.py 100.00% <100.00%> (ø)
tests/test_schemadefs.py 100.00% <ø> (ø)
tests/test_validation_battery.py 88.46% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavlemarinkovic pavlemarinkovic merged commit 44aefc2 into master Oct 9, 2023
@pavlemarinkovic pavlemarinkovic deleted the bugfix/list_of_types branch June 3, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants