Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post AMQP 1.0 Modified Outcome #2095

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Add blog post AMQP 1.0 Modified Outcome #2095

merged 4 commits into from
Oct 11, 2024

Conversation

ansd
Copy link
Member

@ansd ansd commented Oct 10, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Oct 10, 2024

Deploying rabbitmq-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: b4ceb51
Status: ✅  Deploy successful!
Preview URL: https://464bb958.rabbitmq-website.pages.dev
Branch Preview URL: https://modified-outcome.rabbitmq-website.pages.dev

View logs

@ansd ansd marked this pull request as ready for review October 10, 2024 15:56
ansd added a commit to rabbitmq/rabbitmq-server that referenced this pull request Oct 11, 2024
as described in rabbitmq/rabbitmq-website#2095

This commit adds a test case and fixes a bug in the broker to allow
using `array` type in the value of the modified annotations.
ansd added a commit to rabbitmq/rabbitmq-server that referenced this pull request Oct 11, 2024
Support tracking the requeue history as described in
rabbitmq/rabbitmq-website#2095

This commit:
1. adds a test case tracing the requeue history via AMQP 1.0
   using the modified outcome and
2. fixes bugs in the broker which crashed if a modified message
   annotation value is an AMQP 1.0 list, map, or array.

Modified annotations are stored as tagged values from now on.
These modified annotations can be consumed via AMQP 1.0, but not via
AMQP 0.9.1, which is okay.
ansd added a commit to rabbitmq/rabbitmq-server that referenced this pull request Oct 11, 2024
Support tracking the requeue history as described in
rabbitmq/rabbitmq-website#2095

This commit:
1. adds a test case tracing the requeue history via AMQP 1.0
   using the modified outcome and
2. fixes bugs in the broker which crashed if a modified message
   annotation value is an AMQP 1.0 list, map, or array.

Modified annotations are stored as tagged values from now on.
These modified annotations can be consumed via AMQP 1.0, but not via
AMQP 0.9.1, which is okay.
which is easier to repro for the blog post reader
ansd added a commit to rabbitmq/rabbitmq-server that referenced this pull request Oct 11, 2024
Support tracking the requeue history as described in
rabbitmq/rabbitmq-website#2095

This commit:
1. adds a test case tracing the requeue history via AMQP 1.0
   using the modified outcome and
2. fixes bugs in the broker which crashed if a modified message
   annotation value is an AMQP 1.0 list, map, or array.

Modified annotations are stored as tagged values from now on.
These modified annotations can be consumed via AMQP 1.0, but not via
AMQP 0.9.1, which is okay.
ansd added a commit to rabbitmq/rabbitmq-server that referenced this pull request Oct 11, 2024
ansd added a commit to rabbitmq/rabbitmq-server that referenced this pull request Oct 11, 2024
Support tracking the requeue history as described in
rabbitmq/rabbitmq-website#2095

This commit:
1. adds a test case tracing the requeue history via AMQP 1.0
   using the modified outcome and
2. fixes bugs in the broker which crashed if a modified message
   annotation value is an AMQP 1.0 list, map, or array.

Complex modified annotation values (list, map, array) are stored as tagged values from now on.
This means AMQP 0.9.1 consumers will not receive modified annotations of
type list, map, or array (which is okay).
ansd added a commit to rabbitmq/rabbitmq-server that referenced this pull request Oct 11, 2024
ansd added a commit to rabbitmq/rabbitmq-server that referenced this pull request Oct 11, 2024
Test the use case described in rabbitmq/rabbitmq-website#2095:

> Rather than relying solely on RabbitMQ's built-in dead lettering tracking via x-opt-deaths,
consumers can customise dead lettering event tracking.
mergify bot pushed a commit to rabbitmq/rabbitmq-server that referenced this pull request Oct 11, 2024
Support tracking the requeue history as described in
rabbitmq/rabbitmq-website#2095

This commit:
1. adds a test case tracing the requeue history via AMQP 1.0
   using the modified outcome and
2. fixes bugs in the broker which crashed if a modified message
   annotation value is an AMQP 1.0 list, map, or array.

Complex modified annotation values (list, map, array) are stored as tagged values from now on.
This means AMQP 0.9.1 consumers will not receive modified annotations of
type list, map, or array (which is okay).

(cherry picked from commit e6818f0)
mergify bot pushed a commit to rabbitmq/rabbitmq-server that referenced this pull request Oct 11, 2024
Test the use case described in
rabbitmq/rabbitmq-website#2095

(cherry picked from commit 855a32a)
mergify bot pushed a commit to rabbitmq/rabbitmq-server that referenced this pull request Oct 11, 2024
Test the use case described in rabbitmq/rabbitmq-website#2095:

> Rather than relying solely on RabbitMQ's built-in dead lettering tracking via x-opt-deaths,
consumers can customise dead lettering event tracking.

(cherry picked from commit 2e90619)
@ansd ansd merged commit 0230c51 into main Oct 11, 2024
2 checks passed
@ansd ansd deleted the modified-outcome branch October 11, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant