Skip to content

Conversation

@Ayanda-D
Copy link
Contributor

@Ayanda-D Ayanda-D commented Oct 2, 2022

Proposed Changes

Elixir formatter was introduced in version 1.6.0. This change ensures
RabbitMQ CLI formatting conforms to Elixir's standard formatting.
Format checking is added to build steps, which means new code
changes will need to run the formatter to ensure successful CLI build.

mix format is also executed for the CLI and contribution notes updated.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@michaelklishin michaelklishin merged commit 8e0810c into rabbitmq:main Oct 3, 2022
michaelklishin added a commit that referenced this pull request Oct 4, 2022
Standardize CLI formatting with mix format (backport #5958)
@Ayanda-D Ayanda-D deleted the mix-format-cli branch October 4, 2022 08:36
HoloRin added a commit that referenced this pull request Oct 4, 2022
Standardize CLI formatting with mix format (backport #5958) (backport #5971)
michaelklishin added a commit that referenced this pull request Oct 4, 2022
Standardize CLI formatting with mix format (backport #5958) (backport #5971) (backport #5983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants