Fix a tie_binding_to_dest_with_keep_while_cond exception on certain auto-delete exchanges (backport #16824)#16825
Merged
Conversation
… auto-delete exchanges The migration ties an auto-delete exchange to having at least one outbound binding (that is, where the exchange in question is the source) via a `keep_while` condition. An exchange without such bindings (e.g. an exchange-to-exchange destination or an `alternate-exchange` target) cannot satisfy it, so Khepri rejects the write with `keep_while_conditions_not_met`. Such exchanges should be skipped, matching the behavior on the `exchange.declare` path. References #16590 #16587. Closes #16823. (cherry picked from commit 0b3c150)
Author
|
Tick the box to add this pull request to the merge queue (same as
|
michaelklishin
added
the
do-not-backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration ties an auto-delete exchange to having at least one outbound binding (that is, where the exchange in question is the source) via a
keep_whilecondition.An exchange without such bindings (e.g. an exchange-to-exchange destination or an
alternate-exchangetarget) cannot satisfy it, so Khepri rejects the write withkeep_while_conditions_not_met.Such exchanges should be skipped, matching the behavior on the
exchange.declarepath.References #16590 #16587 #14902 #15954.
Closes #16823.
This is an automatic backport of pull request #16824 done by [Mergify](https://mergify.com).