Skip to content

Test flake chase (Apr 8, 2026) (backport #15967) (backport #15968)#15969

Closed
mergify[bot] wants to merge 4 commits intov4.2.xfrom
mergify/bp/v4.2.x/pr-15968
Closed

Test flake chase (Apr 8, 2026) (backport #15967) (backport #15968)#15969
mergify[bot] wants to merge 4 commits intov4.2.xfrom
mergify/bp/v4.2.x/pr-15968

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Apr 9, 2026

  1. Give peer-started nodes more than 15s to boot to reduce the probability of CI flakes
  2. Fix a test that assumes that random bytes would never return a valid Erlang term prefix. Yes, it actually happened
  3. Adopt await_condition/2 in several CLI tests that used timer:sleep/1

References #15222.


This is an automatic backport of pull request #15967 done by Mergify.
This is an automatic backport of pull request #15968 done by Mergify.

To prevent CI flakes.

(cherry picked from commit ad537f9)
(cherry picked from commit d0204ef)

# Conflicts:
#	deps/rabbitmq_ct_helpers/src/rabbit_ct_broker_helpers.erl
…valid Erlang terms

(cherry picked from commit 8ce2bc5)
(cherry picked from commit 790730b)
… few places

(cherry picked from commit 2ace9b5)
(cherry picked from commit 94bd83e)
… few places (encore, round 2)

(cherry picked from commit 746250e)
(cherry picked from commit eecc9bb)
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Apr 9, 2026

Cherry-pick of d0204ef has failed:

On branch mergify/bp/v4.2.x/pr-15968
Your branch is up to date with 'origin/v4.2.x'.

You are currently cherry-picking commit d0204ef89f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   deps/rabbit/test/feature_flags_v2_SUITE.erl
	modified:   deps/rabbit/test/rabbit_stream_sac_coordinator_SUITE.erl

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   deps/rabbitmq_ct_helpers/src/rabbit_ct_broker_helpers.erl

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot added the conflicts label Apr 9, 2026
@michaelklishin
Copy link
Copy Markdown
Collaborator

Doh #15966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant