Switch CLI tools to Thoas for JSON serializer; re-enable Dialyzer for 4 plugins#15964
Merged
michaelklishin merged 2 commits intomainfrom Apr 8, 2026
Merged
Switch CLI tools to Thoas for JSON serializer; re-enable Dialyzer for 4 plugins#15964michaelklishin merged 2 commits intomainfrom
michaelklishin merged 2 commits intomainfrom
Conversation
michaelklishin
changed the title
…lugins Elixir 1.18+ introduces a standard library JSON module which conflicts with the `json` library we've been using in CLI tools for `--formatter=json` and such. Since the two Elixir versions are not compatible and we have reasons to not bump Elixir too aggressively just yet, the most pragmatic option was to switch CLI tools to use `thoas`, the Erlang JSON parser RabbitMQ core and HTTP API use. This unblocks Dialyzer runs in four plugins disabled about 10 months ago and reveals a `rabbitmq_mqtt` Dialyzer failure due to a field that was removed from a record but not its type spec. Due to the MQTT plugin issue above, this can only be backported to `v4.3.x`, a `v4.2.x` version will need some tweaks.
at least as closely as practical for RabbitMQ's needs.
michaelklishin
force-pushed
the
mk-double-elixir-dep-on-elixir-1.19
branch
from
221b663 to
ff97d99
Compare
michaelklishin
added a commit
that referenced
this pull request
Apr 9, 2026
Switch CLI tools to Thoas for JSON serializer; re-enable Dialyzer for 4 plugins (backport #15964)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elixir 1.18+ introduces a standard library JSON module which conflicts with the
jsonlibrary we've been using in CLI tools for--formatter=jsonand such.Since the two Elixir versions are not compatible
and we have reasons to not bump Elixir too aggressively just yet, the most pragmatic option was to switch CLI tools to use
thoas, the Erlang JSONparser RabbitMQ core and HTTP API use.
This unblocks Dialyzer runs in four plugins disabled about 10 months ago and reveals a
rabbitmq_mqttDialyzer failure due to a field that was removedfrom a record but not its type spec.
The plugins in question added CLI tools to their
PLT_APPS.Due to the MQTT plugin issue above, this can only
be backported to
v4.3.x, av4.2.xversionwill need some tweaks.