Skip to content

rabbit_semver: handle [more complex] prefixes #15232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcorbacho merged 2 commits into from
Jan 12, 2026
Merged

rabbit_semver: handle [more complex] prefixes #15232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5683a37
rabbit_semver: handle prefixes
michaelklishin Jan 8, 2026
0b1cf1d
Introduce rabbit_semver:normalize_then_format/1, adopt it in rabbitmq…
michaelklishin Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions deps/rabbit/src/rabbit_plugins.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,9 +479,11 @@ is_version_supported("", _) -> true;
is_version_supported("0.0.0", _) -> true;
is_version_supported(_Version, []) -> true;
is_version_supported(VersionFull, ExpectedVersions) ->
%% Pre-release version should be supported in plugins,
%% therefore preview part should be removed
Version = remove_version_preview_part(VersionFull),
%% Development and pre-release versions can be fairly complex,
%% such as "tanzu+rabbitmq.v3.13.12.dev".
%% Use rabbit_semver to extract the "base" X.Y.Z version
%% before doing any comparisons.
Version = rabbit_semver:normalize_then_format(VersionFull),
case lists:any(fun(ExpectedVersion) ->
rabbit_misc:strict_version_minor_equivalent(ExpectedVersion,
Version)
Expand All @@ -493,10 +495,6 @@ is_version_supported(VersionFull, ExpectedVersions) ->
false -> false
end.

remove_version_preview_part(Version) ->
{Ver, _Preview} = rabbit_semver:parse(Version),
iolist_to_binary(rabbit_semver:format({Ver, {[], []}})).

clean_plugins(Plugins) ->
ExpandDir = plugins_expand_dir(),
[clean_plugin(Plugin, ExpandDir) || Plugin <- Plugins].
Expand Down
Loading
Loading