Fix dead lettering crash (backport #12935) #12938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12933
The assumption that
x-last-death-*
annotations must have been set whenever thedeaths
annotation is set was wrong.Reproducation steps, Option 1:
Reproduction steps, Option 2:
The modified test case in this commit was able to repro this crash via Option 2 in the mixed version cluster tests on the
v4.0.x
branch.This is an automatic backport of pull request #12935 done by Mergify.