Peer discovery cleanup: be more defensive #12809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion #12807 for details. rabbit_peer_discovery:normalize/1 can be changed to only return lists of nodes but then there is a number of core code paths that treat a single node as a special "preselected" value. So let's keep that part and convert both sets of nodes to lists before computing the difference.
|
Per discussion with @dumbbell: indeed, the "single value" results of peer discovery is a special case introduced intentionally to allow for a modified seeding (see RabbitMQ 4.0 release notes for details) by certain backends. The cleanup module simply wasn't updated to account for that. |
michaelklishin
added a commit
that referenced
this pull request
Nov 25, 2024
Peer discovery cleanup: be more defensive (backport #12809)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion #12807 for details. This is to avoid an exception when
the cleanup functions perform peer discovery and may get a single node back
instead of a list.
rabbit_peer_discovery:normalize/1can bechanged to only return lists of nodes but then
there is a number of core code paths that
treat a single node as a special "preselected" value.
So let's keep that part and convert both
sets of nodes to lists before computing the
difference.