Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1: Avoid an exception when an AMQP 0-9-1-originating message with expiration set is converted for an MQTT consumer #12710

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Nov 12, 2024

when an AMQP 0-9-1 publisher publishes a message
that has expiration set.

Stack trace was contributed in #12707 by @rdsilio.

Originally submitted against v4.0.x as #12708.

To reproduce the exception:

  1. Start a node with rabbitmq_mqtt enabled
  2. Tail its logs
  3. Install github.com/rabbitmq/omq
  4. omq amqp-mqtt --message-ttl 10s -t /topic/my_topic -T my_topic -C 1

when an AMQP 0-9-1 publisher publishes a message
that has expiration set.

Stack trace was contributed in #12707 by @rdsilio.
@michaelklishin michaelklishin added this to the 4.1.0 milestone Nov 12, 2024
Copy link
Member

@ansd ansd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @michaelklishin !

@ansd ansd merged commit c78bc8a into main Nov 13, 2024
272 of 273 checks passed
@ansd ansd deleted the mk-mc-mqtt-rabbitmq-server-discussion-12707-main branch November 13, 2024 08:20
mergify bot pushed a commit that referenced this pull request Nov 13, 2024
…xpiration set is converted for an MQTT consumer (#12710)

* MQTT: avoid an exception

when an AMQP 0-9-1 publisher publishes a message
that has expiration set.

Stack trace was contributed in #12707 by @rdsilio.

* mc_mqtt_SUITE test for #12707 #12710

* MQTT protocol_interop_SUITE: new test for #12710 #12707

* Simplify tests

---------

Co-authored-by: David Ansari <[email protected]>
(cherry picked from commit c78bc8a)
ansd pushed a commit that referenced this pull request Nov 13, 2024
…xpiration set is converted for an MQTT consumer (#12710)

* MQTT: avoid an exception

when an AMQP 0-9-1 publisher publishes a message
that has expiration set.

Stack trace was contributed in #12707 by @rdsilio.

* mc_mqtt_SUITE test for #12707 #12710

* MQTT protocol_interop_SUITE: new test for #12710 #12707

* Simplify tests

---------

Co-authored-by: David Ansari <[email protected]>
(cherry picked from commit c78bc8a)
michaelklishin added a commit that referenced this pull request Nov 14, 2024
…xpiration set is converted for an MQTT consumer (#12710)

* MQTT: avoid an exception

when an AMQP 0-9-1 publisher publishes a message
that has expiration set.

Stack trace was contributed in #12707 by @rdsilio.

* mc_mqtt_SUITE test for #12707 #12710

* MQTT protocol_interop_SUITE: new test for #12710 #12707

* Simplify tests

---------

Co-authored-by: David Ansari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants