-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Khepri: Mark khepri_db
feature flag as stable
#12682
Draft
dumbbell
wants to merge
27
commits into
main
Choose a base branch
from
mark-khepri_db-as-stable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
mark-khepri_db-as-stable
branch
3 times, most recently
from
November 11, 2024 11:31
0ae5831
to
dffcf0c
Compare
michaelklishin
changed the title
Khepri: Mark
4.1: Khepri: Mark Nov 13, 2024
khepri_db
as stablekhepri_db
feature flag as stable
dumbbell
changed the title
4.1: Khepri: Mark
Khepri: Mark Nov 13, 2024
khepri_db
feature flag as stablekhepri_db
feature flag as stable
[Why] The intent is to have it stable and enabled by default for new deployment in RabbitMQ 4.1.x. To prepare for this goal, it is time to mark the feature flag as stable to let us iron out the library and its integration into RabbitMQ. This is not a commitment at this stage: we will revisit this near the beginning of the release cycle and commit to it or revert to experimental.
…gs_on_init` [Why] We already support that from the environment variable, it is easy to add to the configuration setting.
[Why] With `khepr_db` enabled by default, we need another way to disable it to select Mnesia instead. [How] For Khepri, we force the `khepri_db` feature flag. For Mnesia, we force an empty list, meaning all stable feature flags are disabled by default. Testsuites will have to enable whatever feature flags they need, though they should already do that. While here, change `rjms_topic_selector_SUITE` to only choose Khepri without specifying any feature flags.
[Why] We want to disconnect from the remote cluster nodes we tried to join after a failure to join because it may impact peer discovery when the local node is restarted (as a standalone node). In particular, it may trigger the recovery code of peer discovery that tries to repair a cluster after a node lost its disk entirely. It could also affect the remote cluster as well.
This reverts commit dce5a08.
…ing it from cluster [Why] We want to disconnect a node that was just reset from the remote cluster nodes because it may impact peer discovery when the local node is restarted (as a standalone node). In particular, it may trigger the recovery code of peer discovery that tries to repair a cluster after a node lost its disk entirely. It could also affect the remote cluster as well.
…er removing it from cluster" This reverts commit 50aec18.
…uster" This reverts commit 4062d2a.
dumbbell
force-pushed
the
mark-khepri_db-as-stable
branch
from
November 14, 2024 10:36
65d2040
to
cd02f61
Compare
…used [Why] It helps to detect when the nodes are not in the expected state.
This reverts commit 7175e51.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The intent is to have it stable and enabled by default for new deployment in RabbitMQ 4.1.x.
To prepare for this goal, it is time to mark the feature flag as stable to let us iron out the library and its integration into RabbitMQ.
This is not a commitment at this stage: we will revisit this near the beginning of the release cycle and commit to it or revert to experimental.