Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12557: fall back to system-wide CA certificates (if available) when none are configured for AMQP 1.0 and AMQP 0-9-1 clients such as shovels #12564

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

michaelklishin
Copy link
Member

This is #12557 by @LoisSotoLopez.

Copy link

mergify bot commented Oct 21, 2024

⚠️ The sha of the head commit of this PR conflicts with #12557. Mergify cannot evaluate rules on this PR. ⚠️

Provides a specific function to fix client ssl options, i.e.: apply all
fixes that are applied for TLS listeneres and clients on previous
versions but also sets `cacerts` option to CA certificates obtained by
`public_key:cacerts_get`, only when no `cacertfile` or `cacerts` are
provided.
@michaelklishin michaelklishin force-pushed the cloudamqp-use-public-key-cacerts-get branch from 6086f58 to 3ff7e82 Compare October 21, 2024 22:00
@michaelklishin
Copy link
Member Author

The forced push was a rebase to make sure that #12502 is included (it addresses one specific kind of annoying CT suite flakes).

@michaelklishin michaelklishin added this to the 4.1.0 milestone Oct 21, 2024
@michaelklishin michaelklishin changed the title #12557 #12557: fall back to system-wide CA certificates (if available) when none are configured for AMQP 1.0 and AMQP 0-9-1 clients such as shovels Oct 21, 2024
@michaelklishin michaelklishin merged commit 61f0730 into main Oct 22, 2024
342 checks passed
@michaelklishin michaelklishin deleted the cloudamqp-use-public-key-cacerts-get branch October 22, 2024 00:24
michaelklishin added a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants