QQ: add feature flag to control adding non-voting members. #10664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
qq-non-voters-ff
branch
from
9b21f8f to
f28bd76
Compare
Without a feature flag it is possible to add a member on a newer node with a Ra command format that the other nodes do not yet understand resulting in crashed nodes.
kjnilsson
force-pushed
the
qq-non-voters-ff
branch
from
f28bd76 to
58d26cd
Compare
dumbbell
approved these changes
Mar 5, 2024
michaelklishin
pushed a commit
that referenced
this pull request
Mar 5, 2024
…10664) (#10677) * QQ: add feature flag to control adding non-voting members. Without a feature flag it is possible to add a member on a newer node with a Ra command format that the other nodes do not yet understand resulting in crashed nodes. (cherry picked from commit 58d26cd) # Conflicts: # deps/rabbit/src/rabbit_core_ff.erl * Fix conflict --------- Co-authored-by: Karl Nilsson <[email protected]> Co-authored-by: David Ansari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a feature flag it is possible to add a member on a newer node with a Ra command format that the other nodes do not yet understand resulting in crashed nodes.