Add customizer callback for AMQP connections #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives users of the JMS-client the opportunity to customize the established AMQP connection and e.g. add a `BlockedListener` to the connection. See rabbitmq/rabbitmq-java-client#1415
acogoluegnes
approved these changes
Sep 12, 2024
michaelklishin
approved these changes
Sep 12, 2024
|
@acogoluegnes we have last produced a release in Oct 2023, sounds like we should cut a |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
Add customizer callback for AMQP connections
|
@michaelklishin any chance this can be included in the 2.x version as well? Asking for a friend 😬 |
|
If it turns out to be easy to backport, I have no objections. |
jjank
added a commit
to jjank/rabbitmq-jms-client
that referenced
this pull request
Sep 12, 2024
This gives users of the JMS-client the opportunity to customize the established AMQP connection and e.g. add a `BlockedListener` to the connection. See rabbitmq/rabbitmq-java-client#1415 Backport of rabbitmq#496
jjank
added a commit
to jjank/rabbitmq-jms-client
that referenced
this pull request
Sep 12, 2024
This gives users of the JMS-client the opportunity to customize the established AMQP connection and e.g. add a `BlockedListener` to the connection. See rabbitmq/rabbitmq-java-client#1415 Backport of rabbitmq#496
|
Turns out: Yes - I created a PR #498 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of the discussion Make it easier to detect blocked connections #1415 in rabbitmq-java-client this PR adds a customizer callback for
com.rabbitmq.client.Connection(s) akin to the customizer callback forcom.rabbitmq.client.ConnectionFactory