Skip to content

Make RMQConnectionFactory and RMQDestination compatible with RMQObjectFactory #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Add RMQSession#addShutdownListenerToChannel method
merged 1 commit into from
Jun 4, 2020
Merged

Make RMQConnectionFactory and RMQDestination compatible with RMQObjectFactory #130

merged 1 commit into from
Jun 4, 2020

Conversation

@acogoluegnes
Copy link
Contributor

RMQConnectionFactory#getReference and RMQDestination#getReference now
include enough information to re-create similar instances. All the
properties supported in RMQObjectFactory are now included in
RMQConnectionFactory#getReference.

Fixes #128

@acogoluegnes
Make RMQConnectionFactory and RMQDestination compatible with RMQObjec…
5e04bf1 
…tFactory

RMQConnectionFactory#getReference and RMQDestination#getReference now
include enough information to re-create similar instances. All the
properties supported in RMQObjectFactory are now included in
RMQConnectionFactory#getReference.

Fixes #128
@acogoluegnes acogoluegnes mentioned this pull request Jun 4, 2020
Closed
@l-k-test
Copy link

l-k-test commented Jun 4, 2020

The changes look good.
Again I cannot really comment on all the properties added to the JNDI reference, whether they are all needed and whether some of them are missing.

And adding "roundtrip" tests (RMQDestinationTest) was a nice touch too.

@acogoluegnes
Copy link
Contributor Author

Thanks for the feedback. I added the properties that are supported by the RMQObjectFactory to be at least symmetric.

@michaelklishin michaelklishin merged commit f7f922e into master Jun 4, 2020
@michaelklishin michaelklishin deleted the rabbitmq-jms-client-128-rmq-object-factory-compatibility branch June 4, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rabbitmq-jms 'admin' objects RMQConnectionFactory and RMQDestination are not compatible with RMQObjectFactory

3 participants

@acogoluegnes @l-k-test @michaelklishin