Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw ArgumentOutOfRangeException when table key is too long (> 255) #849

Merged
merged 1 commit into from
May 26, 2020

Conversation

bollhals
Copy link
Contributor

Proposed Changes

As brought up in #845, there was a bug that if a key of a dictionary was longer than 255, it wrote the overflowed byte value and the full byte array. The reader on the other side though was only reading the number of bytes (the overflowed one) and then the followed reads were then off.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin michaelklishin merged commit 2ff39f0 into rabbitmq:master May 26, 2020
michaelklishin added a commit that referenced this pull request May 26, 2020
throw ArgumentOutOfRangeException when table key is too long (> 255)

(cherry picked from commit 2ff39f0)
@michaelklishin michaelklishin added this to the 6.1.0 milestone May 26, 2020
@bollhals bollhals deleted the throwOnLongStringKey branch May 26, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants