Skip to content

Add 'contents: read' to workflow permissions to increase the OpenSSF scorecard of the repo#1880

Merged
lukebakken merged 1 commit intorabbitmq:mainfrom
pavlofilatov1:update-workflow-permissions
Nov 17, 2025
Merged

Add 'contents: read' to workflow permissions to increase the OpenSSF scorecard of the repo#1880
lukebakken merged 1 commit intorabbitmq:mainfrom
pavlofilatov1:update-workflow-permissions

Conversation

@pavlofilatov1
Copy link
Copy Markdown
Contributor

@pavlofilatov1 pavlofilatov1 commented Nov 14, 2025

Proposed Changes

These changes are being introduced to increase the repository's score that is calculated by the OpenSSF Scorecard (GitHub repo) tool.

This Pull Request updates the top-level permissions configuration within repo's GitHub workflows. It sets the default contents permission to read for the workflow token. The changes were done according to the recommendations from Scorecard regarding the token permissions and the discussion of this repository.

Types of Changes

Marked it as Other, but it is not the best choice. I would appreciate a recommendation regarding the right type.

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Other

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

…level for all main workflows of the repository.
@lukebakken lukebakken self-assigned this Nov 14, 2025
@lukebakken lukebakken self-requested a review November 14, 2025 17:29
@lukebakken lukebakken added this to the 7.2.1 milestone Nov 14, 2025
@lukebakken
Copy link
Copy Markdown
Collaborator

@pavlofilatov1 thanks. Ping me when this is ready for review.

@michaelklishin michaelklishin changed the title Workflow permissions were updated. 'contents: read' was added on top … Add 'contents: read' to workflow permissions to increase the OpenSSF scorecard for the repo Nov 14, 2025
@michaelklishin michaelklishin changed the title Add 'contents: read' to workflow permissions to increase the OpenSSF scorecard for the repo Add 'contents: read' to workflow permissions to increase the OpenSSF scorecard of the repo Nov 14, 2025
@pavlofilatov1 pavlofilatov1 marked this pull request as ready for review November 17, 2025 12:49
@pavlofilatov1
Copy link
Copy Markdown
Contributor Author

@lukebakken the PR is ready for review.
Is type of changes as "Other" ok?
And, does check list look ok in this case? Since no core code was changes I guess test related checkmarks are not relevant in this case.

@michaelklishin
Copy link
Copy Markdown
Contributor

@pavlofilatov1 don't worry about the checklist, the contribution process is very straightforward.

You are welcome to sign the RabbitMQ CLA but it's not currently required for client libraries.

@pavlofilatov1
Copy link
Copy Markdown
Contributor Author

pavlofilatov1 commented Nov 17, 2025

You are welcome to sign the RabbitMQ CLA but it's not currently required for client libraries.

@lukebakken Since it is not required I would skip that. Otherwise I have to discuss that Broadcom CLA sign that is required from a company inside my company and that might take some time, unfortunately.

@michaelklishin
Copy link
Copy Markdown
Contributor

This contribution likely counts for a trivial one anyway, it's not even a functional change in the library.

hwinther pushed a commit to hwinther/test that referenced this pull request Mar 7, 2026
[//]: # (dependabot-start)
⚠️  **Dependabot is rebasing this PR** ⚠️ 

Rebasing might not happen immediately, so don't worry if this takes some
time.

Note: if you make any changes to this PR yourself, they will take
precedence over the rebase.

---

[//]: # (dependabot-end)

Updated
[RabbitMQ.Client](https://github.com/rabbitmq/rabbitmq-dotnet-client)
from 7.2.0 to 7.2.1.

<details>
<summary>Release notes</summary>

_Sourced from [RabbitMQ.Client's
releases](https://github.com/rabbitmq/rabbitmq-dotnet-client/releases)._

## 7.2.1

[GitHub
milestone](https://github.com/rabbitmq/rabbitmq-dotnet-client/milestone/77?closed=1)

## What's Changed
* Add 'contents: read' to workflow permissions to increase the OpenSSF
scorecard of the repo by @​pavlofilatov1 in
rabbitmq/rabbitmq-dotnet-client#1880
* Add workflow to check for GHA updates by @​lukebakken in
rabbitmq/rabbitmq-dotnet-client#1887
* Update GHA via `actions-up` by @​lukebakken in
rabbitmq/rabbitmq-dotnet-client#1886
* Added TryComplete instead of comple during channel shutdown by
@​patriktiain in
rabbitmq/rabbitmq-dotnet-client#1885
* Catch all exceptions in HeartbeatWriteTimerCallback and
HeartbeatReadTimerCallback to avoid crash by @​klettier in
rabbitmq/rabbitmq-dotnet-client#1876
* Use dependabot to update actions refs by @​lukebakken in
rabbitmq/rabbitmq-dotnet-client#1896
* Bump github/codeql-action from 3 to 4 by @​dependabot[bot] in
rabbitmq/rabbitmq-dotnet-client#1898
* Bump actions/checkout from 6.0.1 to 6.0.2 by @​dependabot[bot] in
rabbitmq/rabbitmq-dotnet-client#1897
* Bump actions/cache from 5.0.2 to 5.0.3 by @​dependabot[bot] in
rabbitmq/rabbitmq-dotnet-client#1899
* Fix unconditional semaphore release in BasicPublishAsync when Cancell…
by @​EvheniyHlushko in
rabbitmq/rabbitmq-dotnet-client#1901
* Connection recovery: remove recorded bindings of auto-delete entities
by @​michaelklishin in
rabbitmq/rabbitmq-dotnet-client#1906
* Pre-7.2.1 release preparation by @​lukebakken in
rabbitmq/rabbitmq-dotnet-client#1909

## New Contributors
* @​pavlofilatov1 made their first contribution in
rabbitmq/rabbitmq-dotnet-client#1880
* @​patriktiain made their first contribution in
rabbitmq/rabbitmq-dotnet-client#1885
* @​klettier made their first contribution in
rabbitmq/rabbitmq-dotnet-client#1876
* @​dependabot[bot] made their first contribution in
rabbitmq/rabbitmq-dotnet-client#1898
* @​EvheniyHlushko made their first contribution in
rabbitmq/rabbitmq-dotnet-client#1901

**Full Changelog**:
rabbitmq/rabbitmq-dotnet-client@v7.2.0...v7.2.1

Commits viewable in [compare
view](rabbitmq/rabbitmq-dotnet-client@v7.2.0...v7.2.1).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=RabbitMQ.Client&package-manager=nuget&previous-version=7.2.0&new-version=7.2.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants