Allow parent/child relationship in Opentelemetry spans#1779
Allow parent/child relationship in Opentelemetry spans#1779lukebakken merged 1 commit intorabbitmq:mainfrom
Conversation
lmolkova
left a comment
There was a problem hiding this comment.
LGTM from otel semconv perspective!
|
Does it make more sense to remove the TracingLinkType enum, and just have a bool UsePublisherAsParent? |
|
LGTM :) |
Update more tests Change to always link, optionally parent/child Don't create list unless needed Co-authored-by: Liudmila Molkova <limolkova@microsoft.com> Change default to AlwaysParentChildAndLink Remove TracingLinkType enum, use bool UsePublisherAsParent instead
50f0c5f to
89cdb52
Compare
|
Any ETA on when this will be merged/released? |
lukebakken
left a comment
There was a problem hiding this comment.
I'm going on what other people said about this PR 😇
|
@meum - I'm waiting to hear back on this issue to release 7.2.0. If I don't hear back within two weeks, I will finish up what I can for that issue, and will get 7.2.0 out. |
Proposed Changes
Adds an option to set remote span as parent rather than link when propagating Opentelemetry context between the publisher and receiver.
See issue #1666
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments