Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuget CPM support #1599

Merged
merged 1 commit into from
Jun 20, 2024
Merged

nuget CPM support #1599

merged 1 commit into from
Jun 20, 2024

Conversation

WeihanLi
Copy link
Contributor

Proposed Changes

Use the nuget CPM feature to manage the nuget package versions centrally

https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@WeihanLi
Copy link
Contributor Author

submodule project needs to be updated also
rabbitmq/toxiproxy-netcore#1

@WeihanLi WeihanLi marked this pull request as ready for review June 12, 2024 15:03
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WeihanLi whatever text editor you are using is removing the UTF-8 BOM from these files, and creating an unnecessary change. Please revert.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukebakken thanks very much for help, I did not notice this before

@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WeihanLi whatever text editor you are using is removing the UTF-8 BOM from these files, and creating an unnecessary change. Please revert.

@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WeihanLi whatever text editor you are using is removing the UTF-8 BOM from these files, and creating an unnecessary change. Please revert.

@WeihanLi WeihanLi requested a review from lukebakken June 13, 2024 00:39
Update toxiproxy-netcore submodule

Add comments about upgrading, formatting
Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lukebakken lukebakken merged commit 299ccda into rabbitmq:main Jun 20, 2024
11 checks passed
@WeihanLi
Copy link
Contributor Author

thanks for help

@WeihanLi WeihanLi deleted the cpm-support branch June 20, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants