Merged
Conversation
lukebakken
added a commit
that referenced
this pull request
Apr 10, 2023
Even though we do not use the AMQP xml spec files, they should be updated Related to #1336
Merged
The no-route constant is documented in our website: https://rabbitmq.com/amqp-0-9-1-reference.html#constants However, it was missing in the XML spec file, and it was not getting generated with Apigen program. Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
lukebakken
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The no-route constant is documented in our website:
https://rabbitmq.com/amqp-0-9-1-reference.html#constants
However, it was missing in the XML spec file, and it was not getting
generated with Apigen program.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
N/A