Skip to content

Backport 1332 to 6.x#1336

Merged
lukebakken merged 1 commit into6.xfrom
backport-1332
Apr 11, 2023
Merged

Backport 1332 to 6.x#1336
lukebakken merged 1 commit into6.xfrom
backport-1332

Conversation

@Zerpet
Copy link
Copy Markdown
Member

@Zerpet Zerpet commented Apr 5, 2023

Proposed Changes

The no-route constant is documented in our website:

https://rabbitmq.com/amqp-0-9-1-reference.html#constants

However, it was missing in the XML spec file, and it was not getting
generated with Apigen program.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

N/A

@Zerpet Zerpet added this to the 6.5.1 milestone Apr 5, 2023
@Zerpet Zerpet self-assigned this Apr 5, 2023
Comment thread projects/specs/amqp0-9-1.xml
@lukebakken lukebakken self-assigned this Apr 9, 2023
lukebakken added a commit that referenced this pull request Apr 10, 2023
Even though we do not use the AMQP xml spec files, they should be updated

Related to #1336
The no-route constant is documented in our website:

https://rabbitmq.com/amqp-0-9-1-reference.html#constants

However, it was missing in the XML spec file, and it was not getting
generated with Apigen program.

Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants