Skip to content

Misc updates#1322

Merged
lukebakken merged 2 commits into6.xfrom
lukebakken/bump-deps
Mar 22, 2023
Merged

Misc updates#1322
lukebakken merged 2 commits into6.xfrom
lukebakken/bump-deps

Conversation

@lukebakken
Copy link
Copy Markdown
Collaborator

  • net461 -> net462
  • netcoreapp3.1 -> net6.0
  • NuGet package updates

@lukebakken lukebakken self-assigned this Mar 21, 2023
@lukebakken lukebakken added this to the 6.5.0 milestone Mar 21, 2023
Comment thread projects/Unit/Unit.csproj Outdated
Comment thread projects/Apigen/Apigen.csproj Outdated
@bording
Copy link
Copy Markdown
Collaborator

bording commented Mar 21, 2023

@lukebakken I left some comments, but just noticed that this is on the 6.x branch. Changing the TFM from net461 to net462 is a breaking change, so you probably don't want to do that on this branch.

The other TFM changes are all for test/internal projects, so those would be fine to make here.

@lukebakken
Copy link
Copy Markdown
Collaborator Author

Changing the TFM from net461 to net462 is a breaking change, so you probably don't want to do that on this branch

The problem is that net461 is no longer supported - https://learn.microsoft.com/en-us/lifecycle/products/microsoft-net-framework

So this really requires version 7.0 of this library? Even with netstandard2.0 packages being available?

@lukebakken lukebakken requested a review from bording March 21, 2023 22:31
@bording
Copy link
Copy Markdown
Collaborator

bording commented Mar 21, 2023

The problem is that net461 is no longer supported - https://learn.microsoft.com/en-us/lifecycle/products/microsoft-net-framework

So this really requires version 7.0 of this library? Even with netstandard2.0 packages being available?

It is out of support, but that doesn't change that it would be a binary breaking change for anyone still running net461. If they recompiled their project, it should pick up the netstandard2.0 assembly of the library instead. If there aren't any API differences (and IIRC there isn't) then that shouldn't be a compilation breaking change.

Personally, I would just leave this on net461, and instead focus on getting 7.0 out since that clearly indicates breaking changes are happening.

@lukebakken
Copy link
Copy Markdown
Collaborator Author

@bording thanks as always I appreciate your input!

@lukebakken lukebakken force-pushed the lukebakken/bump-deps branch from e3c6826 to eaa72e6 Compare March 21, 2023 22:43
* `net461` -> `net462`
* `netcoreapp3.1` -> `net6.0`
* NuGet package updates

Update projects/Apigen/Apigen.csproj

Co-authored-by: Brandon Ording <bording@gmail.com>

Remove unnecessary package reference

Change netcoreapp3.1 to net6.0
@lukebakken lukebakken force-pushed the lukebakken/bump-deps branch from eaa72e6 to 617c938 Compare March 22, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants