Merged
Conversation
Without specifically setting net6.0 as a target framework, it is impossible to run Apigen project on M1 Macs, because support for M1 Macs was added in .NET 6, according to this post in MS forums [1]. To enable support for .NET 6, we had to add a NuGet dependency. Everything else worked out of the box. [1] https://learn.microsoft.com/en-us/answers/questions/793925/problem-installing-with-dotnet-on-m1-macos-archite Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
Zerpet
force-pushed
the
update-apigen
branch
2 times, most recently
from
2e50039 to
77e2da7
Compare
Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
Zerpet
force-pushed
the
update-apigen
branch
from
77e2da7 to
3cb701a
Compare
Member
Author
|
Looks like I broke the Concourse build as well. I'll look into that 👀 |
Member
Author
|
Fixed CI for this PR 🔨 |
lukebakken
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Without specifically setting net6.0 as a target framework,
it is impossible to run Apigen project on M1 Macs, because
support for M1 Macs was added in .NET 6, according to this
post in MS forums [1].
Apparently, supporting .netstandard2.0 is not enough, at least locally,
to build and run the Apigen project.
This change is needed to enable developers on M1/M2 Macs to
develop code using branch
6.xas base.[1] https://learn.microsoft.com/en-us/answers/questions/793925/problem-installing-with-dotnet-on-m1-macos-archite
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
Marked this change as 'cosmetic' since .NET 6 was already supported via .netstandard2.0,
and this PR is basically adding support for .NET installations on ARM64 chips.
Edit: marked milestone as 6.5.0, but I see no reason why this can't go into 6.4.1, since it's just an internal change for developers.