ObjectDisposedException when connection is closed from the server

[lukebakken]

Describe the bug

Logging FirstChanceExceptions shows some strange ObjectDisposedException:

https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/v7.0.0/projects/RabbitMQ.Client/Impl/Connection.Heartbeat.cs#L164 accessing .Token here can result in an ObjectDisposedException. That is catched, but the comment states that its for the timer

The SetSessionClosingAsync uses a _closingSemaphore that can already be disposed. It seems this isn't gracefully handled in the stacktrace.

https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/v7.0.0/projects/RabbitMQ.Client/Impl/MainSession.cs

I'm not sure if this is causing issues but looking at the code it might be needed that these code paths all need to have exception handling to prevent code not to terminate if these ObjectDisposedExceptions are to be expected.

Reproduction steps

1. Use MassTransit.RabbitMQ 8.3.4
2. Log FirstChanceException
3. Create a consumer and connect to the broker
4. Close the connections on the broker
5. Observe the consumer trying to reconnect

Do this a couple of times and you'll see the related exception

Expected behavior

gracefully handle ObjectDisposedException on all code paths for closed connections

Additional context

Originally reported by @ramonsmits here: #1749

[lukebakken]

@ramonsmits I have created the following branch with a test project, GH-1749, that repeatedly closes connections:

https://github.com/rabbitmq/rabbitmq-dotnet-client/tree/rabbitmq-dotnet-client-1760

I've been running that project for a while now, and don't see any first-chance ObjectDisposedExceptions logged.

Would you mind testing in your environment, using this version?

https://www.nuget.org/packages/RabbitMQ.Client/7.1.0-alpha.0

Thank you!

[lukebakken]

@ramonsmits I am closing this issue as I did not hear back from you, nor could I reproduce it. Please follow up if you have anything else to add.