Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise dependencies needed for v7 release #1480

Closed
thompson-tomo opened this issue Jan 27, 2024 · 2 comments · Fixed by #1481
Closed

Optimise dependencies needed for v7 release #1480

thompson-tomo opened this issue Jan 27, 2024 · 2 comments · Fixed by #1481
Assignees
@lukebakken
Labels
enhancement
Milestone
7.0.0

Comments

@thompson-tomo
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I want my dependencies to be bringing in only the bare minimum dependencies needed and to achieve this framework references should be used wherever possible

Describe the solution you'd like

Dependencies such as System.Memory should have a condition placed on their reference so that it is only added for frameworks which need it.

Describe alternatives you've considered

Accept additional dependencies

Additional context

Is for the v7 release branch
@lukebakken lukebakken self-assigned this Jan 27, 2024
@lukebakken lukebakken added this to the 7.0.0 milestone Jan 27, 2024
@lukebakken
Copy link
Contributor

Feel free to open a PR to implement this. Otherwise, I will close it prior to the version 7 release, since this has not been requested before and does not seem to be a concern for most users of this library.

thompson-tomo added a commit to thompson-tomo/rabbitmq-dotnet-client that referenced this issue Jan 27, 2024
@thompson-tomo
rabbitmq#1480 Use conditional packages for v7 release
9fb5caa
@thompson-tomo thompson-tomo mentioned this issue Jan 27, 2024
Merged
6 tasks
@thompson-tomo
Copy link
Contributor Author

Thanks @lukebakken pr #1481 submitted.

thompson-tomo added a commit to thompson-tomo/rabbitmq-dotnet-client that referenced this issue Feb 3, 2024
@thompson-tomo
rabbitmq#1480 Use conditional packages for v7 release
7818434
thompson-tomo added a commit to thompson-tomo/rabbitmq-dotnet-client that referenced this issue Feb 13, 2024
@thompson-tomo
rabbitmq#1480 Use conditional packages for v7 release
e4a8f3a
lukebakken pushed a commit to thompson-tomo/rabbitmq-dotnet-client that referenced this issue Mar 11, 2024
@thompson-tomo @lukebakken
rabbitmq#1480 Use conditional packages for v7 release
ee9b9a4
thompson-tomo added a commit to thompson-tomo/rabbitmq-dotnet-client that referenced this issue Mar 12, 2024
@thompson-tomo
rabbitmq#1480 Use conditional packages for v7 release
1983490
thompson-tomo added a commit to thompson-tomo/rabbitmq-dotnet-client that referenced this issue Mar 14, 2024
@thompson-tomo
rabbitmq#1480 Use conditional packages for v7 release
6acccc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
enhancement
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

#1480 Use conditional packages for v7 release thompson-tomo/rabbitmq-dotnet-client
2 participants
@lukebakken @thompson-tomo