Add Note

rabbitmq · Oct 3, 2024 · 857cbde · 857cbde
1 parent ec993b3
commit 857cbde
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/projects/RabbitMQ.Client/Impl/ChannelBase.cs b/projects/RabbitMQ.Client/Impl/ChannelBase.cs
@@ -1841,6 +1841,11 @@ await _confirmSemaphore.WaitAsync(cancellationToken)
                         }
                         else
                         {
+                            /*
+                             * Note:
+                             * In the case of `basic.return`, the TCS will have been handled and removed by HandleBasicReturn()
+                             * RabbitMQ still sends `basic.ack`, so the TCS will not be in the dict, hence, TryGetValue here
+                             */
                             if (_confirmsTaskCompletionSources.TryGetValue(deliveryTag, out TaskCompletionSource<bool>? tcs))
                             {
                                 tcs.SetResult(isAck);