* Allow cancellation of final await for publisher confirmation in `Ba…

…sicPublishAsync` * Fix `dotnet format` verification error
rabbitmq · Sep 27, 2024 · 2c03295 · 2c03295
1 parent 6d7e576
commit 2c03295
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/projects/RabbitMQ.Client/Impl/ChannelBase.cs b/projects/RabbitMQ.Client/Impl/ChannelBase.cs
@@ -1070,8 +1070,7 @@ await _confirmSemaphore.WaitAsync(cancellationToken)
 
             if (publisherConfirmationTcs is not null)
             {
-                // TODO timeout?
-                await publisherConfirmationTcs.Task
+                await publisherConfirmationTcs.Task.WaitAsync(cancellationToken)
                     .ConfigureAwait(false);
             }
         }
@@ -1168,8 +1167,7 @@ await _confirmSemaphore.WaitAsync(cancellationToken)
 
             if (publisherConfirmationTcs is not null)
             {
-                // TODO timeout?
-                await publisherConfirmationTcs.Task
+                await publisherConfirmationTcs.Task.WaitAsync(cancellationToken)
                     .ConfigureAwait(false);
             }
         }

diff --git a/projects/Test/Integration/TestAsyncConsumer.cs b/projects/Test/Integration/TestAsyncConsumer.cs
@@ -708,7 +708,7 @@ private async Task ValidateConsumerDispatchConcurrency()
             Assert.Equal(ConsumerDispatchConcurrency, autorecoveringChannel.ConsumerDispatcher.Concurrency);
             Assert.Equal(_consumerDispatchConcurrency, autorecoveringChannel.ConsumerDispatcher.Concurrency);
             await using IChannel ch = await _conn.CreateChannelAsync(
-                new CreateChannelOptions { ConsumerDispatchConcurrency = expectedConsumerDispatchConcurrency});
+                new CreateChannelOptions { ConsumerDispatchConcurrency = expectedConsumerDispatchConcurrency });
             AutorecoveringChannel ach = (AutorecoveringChannel)ch;
             Assert.Equal(expectedConsumerDispatchConcurrency, ach.ConsumerDispatcher.Concurrency);
         }