Allow a default to be set for imagePullSecrets on operator scope #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows for the operator to set a configurable list of imagePullSecrets as the default to use on all Pods created in RabbitmqClusters. If a RabbitmqClusterSpec does not specify imagePullSecrets, the operator will use the value of the environment variable `DEFAULT_IMAGE_PULL_SECRETS` if set to update the RabbitmqClusterSpec. This closes #870
Zerpet
approved these changes
Jan 10, 2022
MirahImage
approved these changes
Jan 13, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Of Changes
This change allows for the operator to set a configurable list of imagePullSecrets
as the default to use on all Pods created in RabbitmqClusters. If a RabbitmqClusterSpec
does not specify imagePullSecrets, the operator will use the value of the environment variable
DEFAULT_IMAGE_PULL_SECRETSif set to update the RabbitmqClusterSpec.This closes #870
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Additional Context
This is a follow-on PR from #858
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny: