Improve cluster deletion #1864
Merged
Improve cluster deletion #1864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 3 issues: * the STS could get delete before deletion label propagated, leading to some pods terminating for a long time, because they didn't skip quorum checks * there was an unnecessary explicit STS deletion * addRabbitmqDeletionLabel was not filtering by namespace, potentially performing operations on wrong/too many pods (if there were multiple clusters with the same name in different namespaces)
Zerpet
approved these changes
May 5, 2025
Member
Zerpet
left a comment
Zerpet
left a comment
There was a problem hiding this comment.
Nothing to object, the solution looks good to me 👍 Glad you figured out the problem!
Out of curiosity, did you consider using CreateOrUpdate() function in removeFinalizer() ?
CreateOrUpdate does essentially what you are doing of Get prior to Update()
Contributor
Author
|
I had not tried before but I've just pushed a commit which uses CreateOrUpdate and seems to work just as well. |
Member
|
Ship it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 3 issues: